yujinrobot / kobuki_core

Core (non-ros) kobuki packages.
68 stars 71 forks source link

Added state where dock_detector = 0 #26

Closed molinadavid closed 4 years ago

molinadavid commented 7 years ago

When the kobuki is attempting to auto dock but there is not an actual docking station, the instance will crash as is only verifying if the dock_detector value is grater than or less than 0 but not when is 0.

alexthegreat63 commented 7 years ago

With this change, the Kobuki still seems to crash in testing when it doesn't find the base. From here, it seems that it is also necessary to make the same state handling in the find_stream method: https://github.com/yujinrobot/kobuki/issues/354 . I will make a fork off of kobuki_core to implement this change and do a pull request.

stonier commented 4 years ago

Superceded by #55.