search

yuler / gh-download

[GitHub CLI] extension for download folders/files
56 stars 0 forks source link

Spaces in file name will fail. #16

Closed ndsizeif closed 1 year ago

ndsizeif commented 1 year ago

Thanks for the useful tool. Files containing spaces can cause problems. Dry run output looks good, but during actual use, the extension tries to download the file strings individually. To reproduce, download a directory with files that contain space characters.

gh dl ryanoasis/nerd-fonts patched-fonts/UbuntuMono
Collection file: `patched-fonts/UbuntuMono/font-info.md` downloading to `patched-fonts/UbuntuMono/font-info.md`
Collection file: `patched-fonts/UbuntuMono/readme.md` downloading to `patched-fonts/UbuntuMono/readme.md`
curl: (6) Could not resolve host: Mono
curl: (6) Could not resolve host: Bold
curl: (6) Could not resolve host: Italic
curl: (6) Could not resolve host: Nerd
curl: (6) Could not resolve host: Font
curl: (6) Could not resolve host: Complete
curl: (6) Could not resolve host: Mono
curl: (6) Could not resolve host: Windows
curl: (6) Could not resolve host: Compatible.ttf
yuler commented 1 year ago

@ndsizeif

Hi, I release a new version v0.6.1 to fix this issue

You can upgrade to v0.6.1, And try it again

gh extension upgrade gh-download # upgrade
gh dl https://github.com/ryanoasis/nerd-fonts/tree/master/patched-fonts/UbuntuMono/Regular/complete # try it again