yuliangguo / Pytorch_Generalized_3D_Lane_Detection

[ECCV 2020] Official PyTorch implementation of 'Gen-LaneNet: a generalized and scalable approach for 3D lane detection'
307 stars 78 forks source link

about pred_hcam and pred_pitch #8

Closed pandiii closed 3 years ago

pandiii commented 3 years ago

Thank you very much for your code, I'm an employee of the national intelligent vehicle innovation center. In LaneNet3D.py, pred_hcam and pred_pitch are obtained by training, but in GeoNet3D.py I found that they're both directly assigned without training. I want to know why assign them directly without training? Maybe I misunderstood, Hope to get your reply ~~ Thank you again for your code!

yuliangguo commented 3 years ago

Thanks for asking. Fixing camera height and angle is indeed a simplified setup such that the design can focus on improving the 3D lanes. In the real scenario, fixing the height may not affect much, but the camera pitch and yaw angle should be estimated online. There are third-party online calibration networks or classic methods to be considered to integrate into this approach.

On Wed, Jan 20, 2021 at 1:40 AM pandiii notifications@github.com wrote:

Thank you very much for your code, I'm an employee of the national intelligent vehicle innovation center. In LaneNet3D.py, pred_hcam and pred_pitch are obtained by training, but in GeoNet3D.py I found that they're both directly assigned without training. I want to know why assign them directly without training? Maybe I misunderstood, Hope to get your reply ~~ Thank you again for your code!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/yuliangguo/Pytorch_Generalized_3D_Lane_Detection/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFMXCZGVHKR6VY5A375EKTS22QJBANCNFSM4WKMMWOQ .

pandiii commented 3 years ago

Thank you for your quick reply! We are doing comparative experiments, including 3D-LaneNet(GM), Gen-LaneNet(Apollo) and GM's latest paper(3D-LaneNet++). Unified use your open source Apollo Synthetic Dataset. And the experimental results you provide as a reference. But I found that GM's hcam and pitch are predicted by a network, yours are as known variables. This results in the unfairness of the experiment. Is this comparison convincing? Maybe I missed some details, hope to get your explanation ~~

yuliangguo commented 3 years ago

Not a problem. In my experiments, I did not use the pose predictor, and give their method fixed values too, so the comparison only focuses on lanes. Unfortunately I did not implement their pose estimator in my repo due to time limit. You may need some extra work to integrate it for both pipelines from my version.

On Wed, Jan 20, 2021 at 10:08 PM pandiii notifications@github.com wrote:

Thank you for your quick reply! We are doing comparative experiments, including 3D-LaneNet(GM), Gen-LaneNet(Apollo) and GM's latest paper(3D-LaneNet++). Unified use your open source Apollo Synthetic Dataset. And the experimental results you provide as a reference. But I found that GM's hcam and pitch are predicted by a network, yours are as known variables. This results in the unfairness of the experiment. Is this comparison convincing? Maybe I missed some details, hope to get your explanation ~~

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/yuliangguo/Pytorch_Generalized_3D_Lane_Detection/issues/8#issuecomment-764404928, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADFMXC6EOJHZUOSS4NOZAGLS27AFBANCNFSM4WKMMWOQ .

pandiii commented 3 years ago

I see. It's consistent if you also give them fixed values. Your code greatly shortens our development and experiment time, as well as the result baseline that you set up. Thanks again!

ElvishElvis commented 3 years ago

@pandiii hello, I am recently conducting the same experiements under similar setting, could we have a closer conversation about this topic under your convenience? Thanks, my email is elvishelvis6@gmail.com