yuvipanda / jupyterhub-ssh

SSH Access to JupyterHubs
BSD 3-Clause "New" or "Revised" License
93 stars 29 forks source link

sftp: fix shebang of jupyterhub-token-verify.py #59

Closed consideRatio closed 3 years ago

consideRatio commented 3 years ago

Closes #58 that describes the critical issue in detail that makes the jupyterhub-sftp entirely broken.

In short, #46 made the Dockerfile stop using venv, but the shebang in the jupyterhub-token-verify.py script referenced a venv specifically but wasn't updated.


UPDATE: I made a mistake, apparently #!/usr/bin/env python3 will fail as the script is invoked by some pam user or similar that doesn't have python3 on path. So, either we update /etc/pam.d/common-auth to always run the script with /usr/bin/python3 or we update the script itself.

I'm not sure what I think makes most sense.