search

yyllff / split-pane-react

Resizable split panes for React.js.
https://yyllff.github.io/split-pane-react
MIT License
95 stars 25 forks source link

feat: Make sashRender prop optional #18

Closed CanPacis closed 7 months ago

CanPacis commented 1 year ago

Sash render prop is already given a default value when using SplitPane component so I wanted to make it optional at the type level as well. See issue.

ezrasingh commented 1 year ago

This is a really useful PR @yyllff can you please review and merge this?

katistix commented 1 year ago

+1 this is useful when working with TypeScript

Yoorana commented 7 months ago

Im facing this issue currently too and this PR will really help, Could this be reviewed please 🙏

CanPacis commented 7 months ago

@Yoorana seems like this repository and the package is not maintained anymore. I will be maintaining it from this point on, you can find the new repo in here and the package in here. I haven't tested anything yet but the build tools need upgrading as well but I will try not to break the API, if anyone intends to use it I recommend this new package.

Yoorana commented 7 months ago

Much apricated and thanks @CanPacis :) Since you just created the new repo dont forget to change the readme since it will be confusing for other people which npm package