search

yyon / grapplemod

Grappling hook mod for Minecraft
GNU General Public License v3.0
36 stars 29 forks source link

[BUG]Crash #107

Open zinsser901224 opened 1 year ago

zinsser901224 commented 1 year ago

Describe the bug Crashed during game launching

Video / Screenshots If applicable, add screenshots to help explain your problem.

Version Mod version and Minecraft version 1.19.2 grappling_hook_mod-1.19.2-1.19.2-v13.jar

Output Log crash-2023-03-07_20.02.47-fml.txt

example log

To Reproduce If you can, steps to reproduce the behavior, e.g.:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Additional context Add any other context about the problem here.

ForgottenUmbrella commented 1 year ago

Looks like it's due to ItemProperties::register (called in ClientSetup::registerPropertyOverride) not being thread-safe, and Forge loading multiple mods in parallel. This is a pretty common error to make: https://github.com/Stereowalker/Survive/issues/243, https://github.com/architectury/architectury-api/issues/378, https://github.com/Infamous-Misadventures/Dungeons-Mobs/issues/182. I'll take a stab at fixing it.