yyon / grapplemod

Grappling hook mod for Minecraft
GNU General Public License v3.0
36 stars 29 forks source link

Try to fix ConcurrentModificationException (#107) #115

Open ForgottenUmbrella opened 1 year ago

ForgottenUmbrella commented 1 year ago

The ItemProperties::register method is not-thread safe, potentially leading to ConcurrentModificationException being thrown on startup. This MR attempts to fix that by enqueuing the ClientSetup::onClientSetup method, based on a similar issue and fix in another mod.

Potentially fixes issue #107. It's hard to test whether the fix actually works because concurrency bugs are a pain to reproduce.