search

yytan25 / pe

0 stars 0 forks source link

View command can include message to ask user to input list command when the persons list is empty #3

Open yytan25 opened 1 year ago

yytan25 commented 1 year ago

Following the flow of the user guide, I tried to input a sample find command, which returned no search results. Then, I attempted to use the view command, which is next in order.

However, when the persons list is empty, the command cannot be used meaningfully, and the following message is shown:

image.png

To improve user experience, it can be stated somewhere in the message, or at least in the user guide, that the user should execute a find -pa or find -sp command first to get a list of people.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Error feedback not helpful enough

I have 0 person in my list. i tried to view someone with view 1, which resulted in error. however, it will be better if the error feedback explains the real reason of the error, which is no person on the list.

Screenshot 2023-11-17 at 16.46.19.png

[original: nus-cs2103-AY2324S1/pe-interim#5401] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The feature flaw proposed does not affect usage, and the current error message is correctly indicating that the index is not valid. We agree that the proposed message could be even more helpful in this specific scenario, but it is not in the scope of current release as it is a very low priority feature.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]