yyueyii / pe

0 stars 0 forks source link

Sort does not work on filtered list #8

Open yyueyii opened 1 week ago

yyueyii commented 1 week ago

Steps to reproduce:

  1. find by name or tag
  2. Sort by name or index

Expected:

Actual:

nus-pe-bot commented 4 days ago

Team's Response

Similar to #238

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

sort command refreshes contact list after find command

Bug description: After executing find, executing sort causes the contact list to refresh.

Steps to replicate: find er

Screenshot 2024-11-15 at 17.08.02.pngAfter executing find er

sort 1 n/

Screenshot 2024-11-15 at 17.09.26.pngAfter executing sort 1 n/

Suggested improvement: Maybe this could be listed in the user guide so users know that they should execute sort command before executing find command to prevent the list from refreshing.


[original: nus-cs2103-AY2425S1/pe-interim#80] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

From the user's point of view, it makes sense that sorting the list displays all the contacts in the sorted order so that the user can easily see the results of the sort command. If the user had used the find command, it is likely that the displayed contacts list has minimal contacts and is hence unlikely that the user would need to sort the displayed list. In the event that the user does want to apply sort on the displayed list, the auto-fill feature using the up-arrow keys can allow the user to easily re-execute the find command after sorting to show the desired results with minimal inconvenience.

Based on the above reasons, we decided to reject the bug since it is the expected and correct behaviour from the user's point of view.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** I disagree with the claim that after using the find command, the displayed list has "minimal contacts" and that it is "unlikely for the user to want to sort the displayed list." A user can find by tag, which would often filter all students of a specific class or module. For TAs, this is a common and practical use case, especially before each lesson, as they prepare to take attendance. It makes far more sense for a TA to sort the students of a specific class for easier attendance taking. Conversely, I cannot think of a realistic scenario where a TA would need to sort all their students across multiple classes or modules. For a TA managing multiple classes, sorting the list of all contacts is both less practical and less relevant. While the team suggests that users can reexecute the find command after sorting, this adds unnecessary inconvenience. Repeating commands is unintuitive and disrupts workflow. Furthermore, given that implementing sorting on a filtered list is quite straightforward, and yet can significantly enhance usability for TAs, I think this is a valid feature flaw.
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** The sorting feature is functional, since it is able to work as intended and successfully sorts the list of all contacts. Hence it is not a functionality bug. Instead, I think it is a feature flaw since it could be easily improved to enhance the effectiveness and usability of the function.
## :question: Issue severity Team chose [`severity.Medium`] Originally [`severity.Low`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]