z-huang / InnerTune

A Material 3 YouTube Music client for Android
GNU General Public License v3.0
4.23k stars 265 forks source link

Swipe to change song in now playing #1017

Open Coolbeans1388 opened 1 year ago

Coolbeans1388 commented 1 year ago

Checklist

Feature description

Latest update removed ability to swipe to change song on now playing screen.

Why do you want this feature?

I miss this feature from last version.

Additional information

No response

z-huang commented 1 year ago

Yeah it's removed because it's not stable. Once I find a better way to implement, I'll add it back.

netrunner-exe commented 1 year ago

Yeah it's removed because it's not stable. Once I find a better way to implement, I'll add it back.

Hi @z-huang! Is it possible this buggy behavior is because the indexes are not updating correctly when a track is swiped, maybe it has something to do with the track indexes in the queue? I had this bug when a track in the queue is moved above what is playing now (and accordingly sometimes on the screen quick picks, maybe also related to queue?). I don't know for sure, just a guess.

z-huang commented 1 year ago

Yeah, it's related to the queue. When the queue is changed, the HorizontalPager will do the animation. Somehow it detects a move action by mistake and change the track accordingly.

Vishcot commented 1 year ago

what if we try to integrate Bottom to Top swiping gestures for changing songs like Resso App, Wynk and Gaana app have now implemented, it is much more convenient and more interactive @z-huang

d4f5409d commented 1 year ago

Retro Music Player has it nicely implemented, you may take a look at their code