z0mt3c / node-restify-swagger

Swagger generation for REST-Services built with node-restify and node.js based on validation schemas of node-restify-validation.
MIT License
29 stars 16 forks source link

Authorizations and Access Control to hide API methods and check access (2nd Attempt) #16

Closed metasection closed 9 years ago

metasection commented 10 years ago

This Pull Request addresses issue #11.

Feedback on implementation is welcome. Pull would be greatly appreciated. Thanks again for building node-restify-swagger.

Usage / Implementation

Hiding routes based on authorization...

coveralls commented 10 years ago

Coverage Status

Coverage decreased (-13.87%) when pulling 364786add28aee65b87b7d45afba2634426120d3 on metasection:master into 5b2f1465711aa1ad3ae2ab43aae57b67aba068d2 on z0mt3c:master.

metasection commented 9 years ago

Any feedback?

z0mt3c commented 9 years ago

Still decreased test coverage

metasection commented 9 years ago

Ok, was hoping for some feedback on the code / tests that were already developed. Glad to know you are still out there ;) Will get some more tests created soon.

z0mt3c commented 9 years ago

Sorry for my short answers... i'm just busy (hope things get a bit more relaxing with the new year) and not really into this project atm. Tests increase confidence.

I wonder if we could extract the filtering out of lib/swagger-doc.js. May be as post processing - or may some more generic filter abstraction? Not really focused on authorization.