hardcoded .lower() for usernames in zabbixconn.py

zabbix-tooling / zabbix-ldap-sync

Sync Zabbix with LDAP directory server

BSD 3-Clause "New" or "Revised" License

50 stars 36 forks source link

hardcoded .lower() for usernames in zabbixconn.py #38

Closed static302 closed 3 years ago

static302 commented 3 years ago

Subject. May be for some reason, but in this case option "--lowercase" is obsolete and confusing. In fact all usernames synced from ldap are lowercased, which leads to a problems when doing some automation utilizing some third party tools matching real ldap sAMAccountName with usernames (aliases) in zabbix. If it's done as it done just because lack of time - may be it will be better to leave usernames "as is" by default?

scoopex commented 3 years ago

Oh i am sorry. Seems to be overseen by the several refactorings.

With release 0.8 you can disable the modification of ldap account ids by using the "--ldap-accountids" flag.