zacharyxzz / pe

0 stars 0 forks source link

Invalid find command followed by valid find command breaks patients list #2

Open zacharyxzz opened 2 weeks ago

zacharyxzz commented 2 weeks ago

Steps:

  1. Ensure that there are some patients in the patients list, in this case I have added two patients: bellam and jack
  2. Enter command: find person n/
  3. Enter command: find person n/ s

Behavior:

  1. In step 2, an error message "Unknown command" was given.
  2. Then in step 3, the message "0 persons listed!" was given.
  3. However, the patients list still shows all patients.
  4. Now, if we enter the list person command, duplicate patients are shown, and the patients list is basically broken.

image.png

image.png

Rationale:

  1. This sequence of commands is decently likely to happen as it involves just 1 typo (entering the command find person n/ ).
  2. This then proceeds to cause the patients list to show inaccurate results.
nus-se-script commented 1 week ago

Your response not required for this bug as the team has accepted the bug as it is.