zaeleus / noodles

Bioinformatics I/O libraries in Rust
MIT License
512 stars 53 forks source link

cram/io/writer/builder: Rename Builder::build_with_writer to Builder::build_from_writer #295

Closed zaeleus closed 2 months ago

zaeleus commented 2 months ago

Also, the CRAM async builder has the function build_with_writer rather than the build_from_writer. I appreciate these are minor things, but thought I would raise them in case you want to move this library towards consistent names across modules/crates. I guess for backwards compatibility we could add the [#[deprecated](https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute) attribute if you want to introduce the consistent named version.

Originally posted by @mbhall88 in https://github.com/zaeleus/noodles/pull/292#issue-2479959661


Builders in noodles use the from preposition instead of with.