zaeonNineZero / NineZero-Gun-Expansion

Addon for MrCrayfish's Gun Mod that adds additional weapons and attachments in an aesthetically simple style.
https://www.curseforge.com/minecraft/mc-mods/ninezeros-gun-mod-addon
GNU General Public License v3.0
6 stars 11 forks source link

Feedback and Suggestions #20

Open GrechHerald opened 6 months ago

GrechHerald commented 6 months ago

General feedback for CGM AVE and NZGE:

Now for the NZGE suggestions:

These are all of my suggestions for the future of NZGE, certainly take your time with these because it is relatively speaking a lot of things thank you for making this awesome addon

zaeonNineZero commented 6 months ago

Phew, that's a lot of stuff! I'll do my best to go through it all.

Some early answers:

  1. Definitely possible. I'll keep peeking around in the CGM source code to see what I can do - the toughest part is probably going to be handling the "explosion" events, rather than adding new items and entities.
  2. Don't think this is possible without a very substantial rework of CGM's code. While I do have plans for a mixin-driven addon to add new features to CGM, secondary-fire attachments would require a massive rework of the mod's code to support it.
  3. That's something that could be added in the near future (post v1.4.0). It would probably come with stat tweaks to the muzzle brake to ensure their functions don't overlap too much.
  4. I'm admittedly not a fan of the ghillie mesh aesthetic for one, but more importantly, I think that breaks too far away from the model style of CGM and NZGE.
  5. Possibly, wouldn't be too hard to make a basic model and give it stats. I might wait on it though to see if I can/can't do anything fancy with it.
  6. Flamethrower would be a very nice addition, but I'd want to do something fancy with it if I made one. (requires a liquid like lava as "fuel"? or fully reload it with a single "canister" item?) Might warrant being an independent addon at that point, but I'll keep it mind nonetheless.
  7. Could do that, and since the P90 uses FN 5.7×28mm ammunition maybe it could be a counterpart to the Rapid SMG and Micro SMG, firing Medium Bullets rather than Basic Bullets. Would be a great way to differentiate it from the other two bullet hoses.
  8. That's funny, I've actually been thinking about adding a folding-style stock as an attachment for the past several weeks now. I can definitely fit that in as post v1.4.0 content.
  9. See above - if I add laser sights then this could be something I do. Unless the laser sight becomes a "tactical slot" attachment in which case a laser grip would be redundant.

Thanks again for the feedback! I'll do a lot of thinking about these extra ideas you've floated.

GrechHerald commented 6 months ago

for the CGM shotgun, I think making it more resemble the Benelli M4 Super 90 (european name for the M1014) some more would help it out actually, maybe with a bit of inspiration taken from the Benelli M3 Super 90 (which is a pump action and semi-auto shotgun hybrid)

can you describe a bit more about this hybrid system? could probably work fine, I've worked with "sounds.json" files before

I see on the grenade launchers, bit unfortunate but I do understand it would basically need forking

fair on the Ghillie Mesh, I might make a very basic one myself in the future for personal use

on the laser sight, I was thinking of it as a choice thing between a grip and itself with the laser grip coming in later as a potential solution (pretty much based on what's already existing in baseline CGM) but if you can manage to make a tactical attachment that'd be nice too

flamethrower could use a single canister item I think that you can craft it with blaze powder and stuff

precisely what I was thinking on the PDW, something that like does 4.8-5.3 damage per shot (if considering an assault rifle with actual balance changes does about 5.6 damage) chambered in medium bullets, awesome to see we both basically thought of the same thing more or less

you're welcome, love your mod

zaeonNineZero commented 6 months ago
  1. I'll also add some of the changes we tossed around in the CGM Discord too.

  2. Sounds that will be played by mods (and not just by commands) need to have a sound event registered, not just defined in the sounds.json. You can see here how NZGE does so. Basically, I can add reload sound events for every gun in NZGE, and retroactively add one for use with CGM's Machine Pistol. Then in sounds.json I can set the sound events to use common reload sound files, which can then be remapped by soundpack creators to other sound files.

  3. The route I take depends on whether I implement an additional attachment category or not (not directly through NZGE at least). I have not come to a verdict on that, but implementing a laser sight as an underbarrel attachment does not necessarily preclude it from being reworked into a tactical attachment down the road.

  4. That is one option. I'd want the canister to fully reload the flamethrower with just one item, so I'd need to do some mixin work on CGM's code to make that work. That might get resolved with another addon mod though.

  5. I was thinking lower damage (>=3.5 damage) with a maxed-out rate of fire like the Micro/Rapid SMGs. It would then fill the same rapid-fire CQC role with a more expensive ammo type, and in return have a better DPS. (Maybe at the cost of accuracy or recoil, nothing is set in stone just yet)

GrechHerald commented 6 months ago

I see I see, thanks again

zaeonNineZero commented 1 month ago

A few updates related to these suggestions, taking my CGM Expanded fork into consideration:

zaeonNineZero commented 1 month ago

(Did not mean to close this issue - reopened it since it's still relevant)

GrechHerald commented 1 month ago

awesome