zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Different component depending the kind of analysis #255

Closed lpatiny closed 2 years ago

lpatiny commented 2 years ago

Currently we have our 'debug' component to display the chart but depending the kind of analysis we should create more specific component.

If the kind is mass please use to display the value the following component with the same interaction and possibly the same recalculation of peaks when zoom in:

https://zakodium-oss.github.io/react-plot/?path=/story/experimental-spectra-mass--advanced-mass-example

I can help if it is not obvious.

wadjih-bencheikh18 commented 2 years ago

Are we supposed to create new component or just add prop to specify which kind

lpatiny commented 2 years ago

New components seems better because we will be super specific and it will become not manageable with props

wadjih-bencheikh18 commented 2 years ago

could you please share with me the data file?

lpatiny commented 2 years ago

You may click on JCAMP-DX.

The mass TAB should be the one with a different component to display the results based on https://zakodium-oss.github.io/react-plot/?path=/story/experimental-spectra-mass--advanced-mass-example.

image