Closed wadjih-bencheikh18 closed 6 months ago
Latest commit: |
689065b
|
Status: | ✅ Deploy successful! |
Preview URL: | https://31949692.react-science.pages.dev |
Branch Preview URL: | https://607-use-14px-as-base-font-si.react-science.pages.dev |
@stropitek Could you please check toobar-item
I used 1.125em which looks good for me
Attention: 13 lines
in your changes are missing coverage. Please review.
Comparison is base (
1dd41a8
) 22.96% compared to head (689065b
) 22.89%. Report is 2 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
It seems like it changes what is displayed in the IR plot.
I don't know how it was before because the story is broken both on main and here.
The 2 parts highlighted in red were not there before and are added by this PR.
The 2 parts highlighted in red were not there before and are added by this PR.
I am making this conclusion based on
It seems like it changes what is displayed in the IR plot.
Yes, I have to fix the tests Making the default font bigger change the display so the zoom result will change for sure.
Tests updated
Making the default font bigger change the display so the zoom result will change for sure.
Yes but a change it font shouldn't make the title of the plot appear / disappear This hints to a potential bug in the implementation
I can merge since the title is now displayed as it should but maybe worth investigating
closes : https://github.com/zakodium-oss/react-science/issues/607