zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Use 14px as base font size #652

Closed wadjih-bencheikh18 closed 6 months ago

wadjih-bencheikh18 commented 6 months ago

closes : https://github.com/zakodium-oss/react-science/issues/607

cloudflare-pages[bot] commented 6 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 689065b
Status: ✅  Deploy successful!
Preview URL: https://31949692.react-science.pages.dev
Branch Preview URL: https://607-use-14px-as-base-font-si.react-science.pages.dev

View logs

wadjih-bencheikh18 commented 6 months ago

@stropitek Could you please check toobar-item I used 1.125em which looks good for me

codecov-commenter commented 6 months ago

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (1dd41a8) 22.96% compared to head (689065b) 22.89%. Report is 2 commits behind head on main.

Files Patch % Lines
...app/kinds/iv/plot-view/IvPlotVariablesSelector.tsx 0.00% 7 Missing :warning:
src/app/kinds/mass/MeasurementMassPlot.tsx 0.00% 2 Missing :warning:
src/components/toolbar/Toolbar.tsx 0.00% 2 Missing :warning:
src/app/helpers/react-plot.tsx 0.00% 1 Missing :warning:
stories/components/form.stories.tsx 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #652 +/- ## ========================================== - Coverage 22.96% 22.89% -0.07% ========================================== Files 221 221 Lines 13039 13065 +26 Branches 235 235 ========================================== - Hits 2994 2991 -3 - Misses 9956 9985 +29 Partials 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stropitek commented 6 months ago

It seems like it changes what is displayed in the IR plot.

I don't know how it was before because the story is broken both on main and here.

CleanShot 2024-02-12 at 14 11 25

The 2 parts highlighted in red were not there before and are added by this PR.

stropitek commented 6 months ago

The 2 parts highlighted in red were not there before and are added by this PR.

I am making this conclusion based on CleanShot 2024-02-12 at 14 13 31

wadjih-bencheikh18 commented 6 months ago

It seems like it changes what is displayed in the IR plot.

Yes, I have to fix the tests Making the default font bigger change the display so the zoom result will change for sure.

wadjih-bencheikh18 commented 6 months ago

Tests updated

stropitek commented 6 months ago

Making the default font bigger change the display so the zoom result will change for sure.

Yes but a change it font shouldn't make the title of the plot appear / disappear This hints to a potential bug in the implementation

I can merge since the title is now displayed as it should but maybe worth investigating