Closed wadjih-bencheikh18 closed 6 months ago
Latest commit: |
4a1ebec
|
Status: | ✅ Deploy successful! |
Preview URL: | https://fa6ab21f.react-science.pages.dev |
Branch Preview URL: | https://650-show-example-of-stacked.react-science.pages.dev |
Attention: 262 lines
in your changes are missing coverage. Please review.
Comparison is base (
1dd41a8
) 22.96% compared to head (ef50354
) 22.73%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I got insperation from weight and biases platform
The new layout with grouped action in the table header is great 👍🏻
I noticed that the issue with the direction of the animation is still there (so not a storybook issue afterall?). I'm creating another issue for that.
In this PR, can you make this button a dropdown with the choices:
I noticed that the issue with the direction of the animation is still there (so not a storybook issue afterall?). I'm creating another issue for that.
Not the case for me, which navigator are you using?
I can reproduce with Chrome and Firefox.
I can reproduce with Chrome and Firefox.
I found out that in local is diffrent then here.
In this PR, can you make this button a dropdown with the choices:
Implemented.
Last thing: can the delete button remove selected instead of all.
Remove all should be select all then delete selected
I found out that in local is diffrent then here.
Do you have any interpretation of that? it works perfectly only in the developement version
Do you have any interpretation of that? it works perfectly only in the developement version
It's probably related to strict mode since it is enabled in the app and disabled in the storybook (and always disabled in prod).
So without strict mode it seems to not work.
Their documentation does not seem to be affected by that. Maybe see if you are able to have a working example based on their documentation. And then from that see how you need to change it to reproduce the bug.
The most notable consequence on the behaviour of react when using strict mode is that it re-runs effects in development.
Closes : https://github.com/zakodium-oss/react-science/issues/650 Closes : https://github.com/zakodium-oss/react-science/issues/651