zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Use stacked panel for measurement info panel #655

Closed wadjih-bencheikh18 closed 6 months ago

wadjih-bencheikh18 commented 6 months ago

Closes : https://github.com/zakodium-oss/react-science/issues/650 Closes : https://github.com/zakodium-oss/react-science/issues/651

cloudflare-pages[bot] commented 6 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a1ebec
Status: ✅  Deploy successful!
Preview URL: https://fa6ab21f.react-science.pages.dev
Branch Preview URL: https://650-show-example-of-stacked.react-science.pages.dev

View logs

codecov-commenter commented 6 months ago

Codecov Report

Attention: 262 lines in your changes are missing coverage. Please review.

Comparison is base (1dd41a8) 22.96% compared to head (ef50354) 22.73%.

Files Patch % Lines
src/app/panels/measurements/MeasurementsTable.tsx 0.00% 120 Missing :warning:
src/app/panels/measurements/MeasurementsPanel.tsx 0.00% 37 Missing :warning:
...pp/panels/measurements/measurementPanelContext.tsx 0.00% 31 Missing and 1 partial :warning:
...pp/panels/measurements/MeasurementColorPreview.tsx 0.00% 30 Missing :warning:
...anels/measurements/MeasurementVisibilityToggle.tsx 0.00% 23 Missing :warning:
...panels/measurements/MeasurementsPanelAccordion.tsx 0.00% 14 Missing and 1 partial :warning:
src/app/panels/measurements/index.ts 0.00% 5 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #655 +/- ## ========================================== - Coverage 22.96% 22.73% -0.23% ========================================== Files 221 222 +1 Lines 13039 13167 +128 Branches 235 236 +1 ========================================== Hits 2994 2994 - Misses 9956 10083 +127 - Partials 89 90 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wadjih-bencheikh18 commented 6 months ago

I got insperation from weight and biases platform image

stropitek commented 6 months ago

The new layout with grouped action in the table header is great 👍🏻

I noticed that the issue with the direction of the animation is still there (so not a storybook issue afterall?). I'm creating another issue for that.

CleanShot 2024-02-12 at 11 38 44

In this PR, can you make this button a dropdown with the choices:

wadjih-bencheikh18 commented 6 months ago

I noticed that the issue with the direction of the animation is still there (so not a storybook issue afterall?). I'm creating another issue for that.

Not the case for me, which navigator are you using?

targos commented 6 months ago

I can reproduce with Chrome and Firefox.

wadjih-bencheikh18 commented 6 months ago

I can reproduce with Chrome and Firefox.

I found out that in local is diffrent then here.

wadjih-bencheikh18 commented 6 months ago

In this PR, can you make this button a dropdown with the choices:

Implemented.

stropitek commented 6 months ago

Last thing: can the delete button remove selected instead of all.

Remove all should be select all then delete selected

wadjih-bencheikh18 commented 6 months ago

I found out that in local is diffrent then here.

Do you have any interpretation of that? it works perfectly only in the developement version

stropitek commented 6 months ago

Do you have any interpretation of that? it works perfectly only in the developement version

It's probably related to strict mode since it is enabled in the app and disabled in the storybook (and always disabled in prod).

So without strict mode it seems to not work.

Their documentation does not seem to be affected by that. Maybe see if you are able to have a working example based on their documentation. And then from that see how you need to change it to reproduce the bug.

stropitek commented 6 months ago

The most notable consequence on the behaviour of react when using strict mode is that it re-runs effects in development.

https://react.dev/reference/react/StrictMode