search

zakodium-oss / react-science

React components and tools to build scientific applications.
https://react-science.pages.dev
MIT License
3 stars 6 forks source link

Add hover option for popover toolbar trigger #666

Closed moonayyur closed 6 months ago

moonayyur commented 6 months ago

closes #658

cloudflare-pages[bot] commented 6 months ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ae7f8c7
Status: ✅  Deploy successful!
Preview URL: https://3de3d2c5.react-science.pages.dev
Branch Preview URL: https://658-add-story-with-hover-pop.react-science.pages.dev

View logs

codecov-commenter commented 6 months ago

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (c65df27) 22.34% compared to head (ae7f8c7) 22.06%. Report is 4 commits behind head on main.

Files Patch % Lines
stories/components/toolbar.stories.tsx 0.00% 35 Missing :warning:
src/components/toolbar/Toolbar.tsx 50.00% 10 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #666 +/- ## ========================================== - Coverage 22.34% 22.06% -0.29% ========================================== Files 221 221 Lines 13193 13313 +120 Branches 236 236 ========================================== - Hits 2948 2937 -11 - Misses 10155 10286 +131 Partials 90 90 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

stropitek commented 6 months ago

Can you shorten the the duration of the popover transition so that menus don't overlap?

Don't know if it should be 0 or just something smaller.