Closing a dialog opens trigger tooltip

zakodium-oss / react-science

React components and tools to build scientific applications.

https://react-science.pages.dev

MIT License

3 stars 6 forks source link

Closed targos closed 5 months ago

targos commented 5 months ago

Reproduce:

I think it's a case of https://blueprintjs.com/docs/#core/components/tooltip.combining-with-popover and we should decide to either set shouldReturnFocusOnClose={false} on the relevant dialogs, or openOnTargetFocus={false} on the Toolbar.Item.

/cc @stropitek

stropitek commented 5 months ago

setting shouldReturnFocusOnClose={false} is a better option (for UX, probably not for DX because cannot enforce it on every dialog) IMO

targos commented 5 months ago

This affects a bunch of dialogs on NMRium that are opened from a toolbar button.