search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

Add support for multiple channels #498

Closed aermakov-zalando closed 6 years ago

aermakov-zalando commented 6 years ago

stups_auto_configuration: fetch and configure LatestTaupageStagingImage and LatestTaupageDevImage as well.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 89.575% when pulling 6aa6068e3f86d1ecdc576b2b1bd4ec3095a562c8 on taupage-channels into 3be07b32459ee1eae1b922b990082a4b8a8da628 on master.

mikkeloscar commented 6 years ago

Should this maybe be documented in the README?

aermakov-zalando commented 6 years ago

@mikkeloscar I'll create a separate PR to STUPS documentation later. The existing README doesn't have a lot of Taupage documentation, so I don't think it makes sense to document this change here.

mikkeloscar commented 6 years ago

:+1:

szuecs commented 6 years ago

@jmcs does it requires another change? For me this looks good

aermakov-zalando commented 6 years ago

I've removed the TaupageChannel property from the TaupageAutoScalingGroup component. Image: LatestTaupageStagingImage is a bit more verbose, but this is an already documented way of selecting an AMI.

aermakov-zalando commented 6 years ago

👍

jmcs commented 6 years ago

👍