search

zalando-stups / senza

Deploy immutable application stacks and create and execute AWS CloudFormation templates in a sane way
https://pypi.python.org/pypi/stups-senza
Other
96 stars 72 forks source link

change in the strategy to report instances #547

Closed lmineiro closed 5 years ago

lmineiro commented 5 years ago

This small change seems to be enough to allow reporting instances managed by Elastigroups.

Only AWS can set aws: prefixed tags. Instances created by the Elastigroups don't have the aws:cloudformation:stack-name tag that was used to filter instances.

Pragmatically, I believe that the Name tag contains exactly the same information, although the guarantee that it was created by CloudFormation no longer exists.

If this new approach doesn't sound reasonable, please share the particular uses cases or assumptions where this change will break.

This also changed the instance state filtering to the server side for some micro optimization.

This updates #517

lmineiro commented 5 years ago

:+1:

jmcs commented 5 years ago

:+1: