search

zalando-stups / yourturn

The frontend/developer console for the STUPS infrastructure
http://docs.stups.io/en/latest/components/yourturn.html
Apache License 2.0
8 stars 7 forks source link

#507 Allow bucket name prefix gs:// #508

Closed mikkeloscar closed 8 years ago

mikkeloscar commented 8 years ago

This makes it possible to add google cloud storage buckets using the schema gs://.

Close #507

Related change in mint-storage: https://github.com/zalando-stups/mint-storage/pull/25

Eventually the UI should propably also mention Google cloud storage instead of just s3. But for now I think it should be as it is to not confuse most people who don't care about this alpha feature. These changes are tracked here: https://github.com/zalando-stups/mint-storage/issues/26

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 89.382% when pulling e30e2b70b6c7ba3a99695b483b3e923670fa97cc on mikkeloscar:feature/allow-gs-bucket into f1810b11968cfc4f0d12ee06f14cc0b468b98326 on zalando-stups:master.

prayerslayer commented 8 years ago

Hmmm okay, trusting you there. :grin:

prayerslayer commented 8 years ago

👍

mikkeloscar commented 8 years ago

We would like to write some documentation where we mention this "feature". What is needed for this to be merged/deployed within the next days? :)

prayerslayer commented 8 years ago

Your thumbs-up :wink:

mikkeloscar commented 8 years ago

That I can manage.

mikkeloscar commented 8 years ago

:+1:

prayerslayer commented 8 years ago

Rolled out.