510 include app dynamics agent for kpi messurements

neremic commented 8 years ago

included appdynamics script. writing script to static /dist/ folder with replaced appKey from environment variable

coveralls commented 8 years ago

Coverage remained the same at 89.382% when pulling 9b24bfc68774665b4f69d0ed511402d301802116 on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

coveralls commented 8 years ago

Coverage remained the same at 89.382% when pulling 9b24bfc68774665b4f69d0ed511402d301802116 on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

coveralls commented 8 years ago

Coverage remained the same at 89.382% when pulling 9b24bfc68774665b4f69d0ed511402d301802116 on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

prayerslayer commented 8 years ago

Looks good, a couple of suggestions though:

Please don't commit stuff that will be automatically generated (/dist/adrum.js)
We can delete monitoring/appdynamics.js then
A better name for the environment variable could be APPDYNAMICS_RUM_KEY, so we know it's about end user monitoring?
Would be awesome if we would load adrum.js only if the key is actually set.

coveralls commented 8 years ago

Coverage increased (+0.06%) to 89.446% when pulling fdfc25c6c50e5de88440df51d20802a204fc0dcf on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

coveralls commented 8 years ago

Coverage increased (+0.06%) to 89.446% when pulling fdfc25c6c50e5de88440df51d20802a204fc0dcf on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

coveralls commented 8 years ago

Coverage increased (+0.06%) to 89.446% when pulling 6f559e5f595465f0ad29682d23782b03e87fd445 on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

neremic commented 8 years ago

:+1:

coveralls commented 8 years ago

Coverage increased (+0.06%) to 89.446% when pulling c5723ee1ea47952bc3699f222d4a3b3c0f249fad on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

coveralls commented 8 years ago

Coverage increased (+0.06%) to 89.446% when pulling c5723ee1ea47952bc3699f222d4a3b3c0f249fad on 510-Include-AppDynamics-agent-for-KPI-messurements into 2abef4e6b0c785bdb914374ba60228b91c63fa77 on master.

prayerslayer commented 8 years ago

👍

harti2006 commented 8 years ago

:+1:

neremic commented 8 years ago

:+1:

zalando-stups / yourturn

510 include app dynamics agent for kpi messurements #511