search

zalando-stups / yourturn

The frontend/developer console for the STUPS infrastructure
http://docs.stups.io/en/latest/components/yourturn.html
Apache License 2.0
8 stars 7 forks source link

Links are not actual links in the sidebar (prevents from opening in a new tab) #532

Open zaynetro opened 7 years ago

zaynetro commented 7 years ago

The links in the sidebar are <span> elements which prevents users from opening them in a new tab.

Ex: https://github.com/zalando-stups/yourturn/blob/2abef4e6b0c785bdb914374ba60228b91c63fa77/client/lib/yourturn/src/sidebar/sidebar.jsx#L117

Just by changing them to <a> element will resolve a lot of frustration users have.

Do you think this needs fixing? I can do a pull request with the change.

hjacobs commented 7 years ago

@neremic is this something you can answer (or your team)?

zaynetro commented 7 years ago

Any progress on this one?