vetinari commented 4 years ago

we limit the amount of captures being sent to opsgenie to half of the max payload size - the rest is small and should not exceed 1-2kB in normal usage. The captures are visible in the alert detail page also. The include_captures=True is a convenience feature. It is better to drop the captures than not to send out the page

codecov[bot] commented 4 years ago

Codecov Report

Merging #436 into master will increase coverage by 0.06%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage    75.4%   75.47%   +0.06%     
==========================================
  Files          81       81              
  Lines        6047     6063      +16     
==========================================
+ Hits         4560     4576      +16     
  Misses       1487     1487

Impacted Files	Coverage Δ
...rker_monitor/zmon_worker/notifications/opsgenie.py	`100% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab077af...c2a2186. Read the comment docs.

pitr commented 4 years ago

:+1:

marcinzaremba commented 4 years ago

👍

zalando-zmon / zmon-worker

fix: too large captures for opsgenie #436

Codecov Report