search

zalando / go-keyring

Cross-platform keyring interface for Go
MIT License
881 stars 86 forks source link

Inline shellescape dependency #117

Closed williammartin closed 4 days ago

williammartin commented 2 weeks ago

Description

This PR relates to the discussion in https://github.com/zalando/go-keyring/pull/113 about the shellescape dependency using a vanity URL and practical solutions for avoiding that.

From my point of view, the dependency is small and stable so the risk of inlining this is low. I understand if you'd prefer not to though.

mikkeloscar commented 2 weeks ago

Let's put it under internal so we don't become a new public package for this :)

https://go.dev/doc/go1.4#internalpackages

williammartin commented 2 weeks ago

Cool, I also uhh... remembered to actually use it. 😅

mikkeloscar commented 2 weeks ago

👍

szuecs commented 2 weeks ago

:+1: