Closed ktsypkina closed 9 months ago
Attention: Patch coverage is 75.00000%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 77.25%. Comparing base (
9315868
) to head (ae1d160
). Report is 2 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...in/org/zalando/zally/core/DefaultContextFactory.kt | 75.00% | 0 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:+1:
Oh, by the way, there is a drop in coverage. Can you think of a new test case covering it?
Oh, by the way, there is a drop in coverage. Can you think of a new test case covering it?
I've added a new test case before but it's not recognising the new test case as one covering string input scenario
:+1:
👍
Addresses https://github.com/zalando/zally/issues/1445 As Zally does not support validation for relative refs, no new test cases to cover this scenario
After upgrading to io.swagger.parser.v3:swagger-parser:2.1.9 (from 2.0.32) the test case was failing due to different error message.
This error occured because of changes in OpenAPIDeserializer:
rootMap = new ObjectMapper().convertValue(rootNode, Map.class);
the convert to rootMap was introduced before trying to parse the rootNode. That's why it is not setting the correct message in the result.Before the upgrade the message was
attribute openApi is not of type "object"
After upgrade the
IllegalArgumentException
is handled by the library itself, setting the message toAligned with @tkrop on the fix: handle this exception as violation of rule #101 Since there is 0 attributes in test example
"no swagger definition"
it is handled as ParseResult.NotApplicable with following details: