Add `Stat` protobuf - Githubissues

zaphiro-technologies / protobuf

A repository including protocol buffer used in Zaphiro's platform

Apache License 2.0

0 stars 0 forks source link

Closed hiimjako closed 7 months ago

hiimjako commented 7 months ago

Created Stat protobuf

[x] I have used a PR title that is descriptive enough for a release note.
[ ] I have tested these changes locally.
[ ] I have added appropriate tests or updated existing tests.
[ ] I have tested these changes on a dedicated VM or a customer VM [name of the VM]
[ ] I have added appropriate documentation or updated existing documentation.

barecheck[bot] commented 7 months ago

Total: 18.24% Your code coverage diff: 0.00% ▴ ✅ All code changes are covered

chicco785 commented 7 months ago

@MarcoPignati what do you think, should the stat be in the grid package, or it's better a separate package?

chicco785 commented 7 months ago

@MarcoPignati what do you think, should the stat be in the grid package, or it's better a separate package?

maybe we could create a c37.118 package, and move there stats and conf

MarcoPignati commented 7 months ago

yes, it is not a grid thing. It's really a IEEE C37.118 specific thing (as for the CFG-1/2/3 and commands) so I'd go for a separate package.

hiimjako commented 7 months ago

@chicco785 tiny review after the updates? :pray:

chicco785 commented 7 months ago

:shipit: !