search

zaphiro-technologies / protobuf

A repository including protocol buffer used in Zaphiro's platform
Apache License 2.0
0 stars 0 forks source link

[Bug] id consistency across messages #8

Closed chicco785 closed 11 months ago

chicco785 commented 11 months ago

Describe the bug

Different messages are currently using different id fields. E.g. data uses uuid, fault uses id. CIM uses mRID.

@tejo @hiimjako @kwitekrac what's your take?

Expected Behavior

Consistency :)

Steps To Reproduce

No response

Exceptions (if any)

No response

Version

No response

hiimjako commented 11 months ago

In my opinion, it depends on what this id refers to. If it is a unique identifier for the message, fault, or CIM, I would prefer the standard id. If it refers to a foreign key, I would use something more idiomatic, such as producerId, PmuId, etc. These are my 2 cents

tejo commented 11 months ago

I don’t have any personal preference between UUID, ID, etc. Let’s choose one and stick with it :D