search

zappa / Zappa

Serverless Python
https://zappa.ws/zappa
MIT License
3.35k stars 362 forks source link

Feature/ephemeral storage #1259

Closed Meepit closed 1 year ago

Meepit commented 1 year ago

Description

Adds the ability to set ephemeral_storage for the deployed lambda, using a newly added setting

{
   ...
   ephemeral_storage: { "Size": 1024 }
}

There has been a PR open for quite some time now https://github.com/zappa/Zappa/pull/1125 but it appears to have gone stale and the requested changes haven't been followed up on. I've added the requested tests in this PR.

GitHub Issues

https://github.com/zappa/Zappa/issues/1120

monkut commented 1 year ago

@Meepit Can you check the testcase, it appears to be failing.

FAILED tests/tests.py::TestZappa::test_load_settings_ephemeral_storage_overwrite - KeyError: 'ephemeral_storage'

Meepit commented 1 year ago

@Meepit Can you check the testcase, it appears to be failing.

FAILED tests/tests.py::TestZappa::test_load_settings_ephemeral_storage_overwrite - KeyError: 'ephemeral_storage'

@monkut That's been fixed now, if you could please re-run the workflows 🙏

coveralls commented 1 year ago

Coverage Status

coverage: 74.605% (+0.04%) from 74.564% when pulling c725098a7c973f5bcee12409e0d5082a57de529d on Meepit:feature/ephemeral-storage into 67b137784d4faa13da9d83a332b17d9e1d46aaad on zappa:master.