extend SQS event handler

zappa / Zappa

Serverless Python

https://zappa.ws/zappa

MIT License

3.35k stars 362 forks source link

extend SQS event handler #1325

Closed eviltwin closed 4 months ago

eviltwin commented 7 months ago

Description

report_batch_item_failures for partial batch processing
maximum_concurrency to provide limits to SQS event source scaling
remove outdated documentation about FIFO queues being unsupported

eviltwin commented 7 months ago

It was quite a small extension of the existing SQS handler, so I wasn't sure how much documentation would need adding for it... I'm happy to elaborate more on what I put, but the existing options didn't come with much explainer so I wasn't sure if that was a deliberate choice or not.

I corrected the FIFO docs part mostly in passing (I have confirmed that a FIFO queue works just fine).

coveralls commented 7 months ago

coverage: 74.655% (-0.2%) from 74.81% when pulling 61f840741abe4785ff82ba0644e9e1c1e3fc644d on eviltwin:master into a38058b1bc48407d4515d77db5c2cd60ea73e25a on zappa:master.

eviltwin commented 7 months ago

@monkut thanks, I'd looked for the test coverage when SQS events were originally implemented but I couldn't find them. I'll try to find the time in the next week to add coverage in the places you indicated :)

github-actions[bot] commented 4 months ago

Hi there! Unfortunately, this PR has not seen any activity for at least 90 days. If the PR is still relevant to the latest version of Zappa, please comment within the next 10 days if you wish to keep it open. Otherwise, it will be automatically closed.

github-actions[bot] commented 4 months ago

Hi there! Unfortunately, this PR was automatically closed as it had not seen any activity in at least 100 days. If the PR is still relevant to the latest version of Zappa, please open a new PR.