zappa / Zappa

Serverless Python

https://zappa.ws/zappa

MIT License

3.35k stars 362 forks source link

:bug: :wrench: fix Zappa.create_handler_venv win32 case wherestderror_result is None #1353

Open monkut opened 2 months ago

monkut commented 2 months ago

Description

Update Zappa.create_handler_venv, so that when the result from pip_process.communicate() returns None for stderr, an unrelated exception is NOT raised, and zappa.create_handler_venv proceeds as expected.

Currently, the code assumes a str value is returned, but on win32 systems, it appears that None may be returned.

GitHub Issues

1342

coveralls commented 1 month ago

coverage: 74.783% (+0.1%) from 74.648% when pulling c9a7b79b93a738b824f0415512ce4f094f9c07a9 on fix/win-slimhandler-error-handling-issue1342 into b00312d35a1ff57923053e5e8e60857e1f0d6912 on master.