zaps166 / QMPlay2

QMPlay2 is a video and audio player which can play most formats and codecs.
GNU Lesser General Public License v3.0
814 stars 171 forks source link

[Idea] New icons for modules or more... #34

Closed varlesh closed 8 years ago

varlesh commented 8 years ago

Your icons have different style, i'm create new. Maybe you like that? :) screenshot_20160628_091837 Now available 32px icons for modules on SVG.

varlesh commented 8 years ago

All, preview: screenshot_20160628_120702

zaps166 commented 8 years ago

Do you want to add these icons to QMPlay2? If yes - I'll create icon scheme feature for QMPlay2 (later). For this I need to attach all icons in SVG and its name (also author name in text file).

varlesh commented 8 years ago

Yes, if you want and like this icons. Do you agree? Need other icons - main logo, and actions icons (i think this icons used on Windows only, but i can create this icons for better looking one style if you need)?

varlesh commented 8 years ago

For example, main logo: screenshot_20160628_152126

zaps166 commented 8 years ago

Current main logo is OK for me (The only icon which I've done (+ the blue next/prev icons). It was about 8 years ago for QMPlay1) :smiley:

You can create the new QMPlay2 icon style which can be chosen in settings. I'll also think about extending the current default icons, but they are hicolor + original logos like OpenGL or X11...

zaps166 commented 8 years ago

About the new icons:

varlesh commented 8 years ago

Ok, i'm create git-repo and add new style icons. You can add this style later on player and issues. I think this will be comfortable for you and me.

zaps166 commented 8 years ago

OK, so I'll use your icons if the new feature will be available :) You can paste link to your repo here. Thanks!

varlesh commented 8 years ago

https://github.com/varlesh/QMPlay2-Concept

varlesh commented 8 years ago

Inputs, DirectX and Modplug fixed

varlesh commented 8 years ago

@zaps166 gui-icons added

varlesh commented 8 years ago

16px screenshot_20160628_192859 22px screenshot_20160628_192842

varlesh commented 8 years ago

and modules 32px (fixed) screenshot_20160628_193130

zaps166 commented 8 years ago

Thanks :)

I've got one question - modules icons are on black background, not transparent - is it OK? And how does it look on transparent background for you?

And I wonder what about HiDPI - QMPlay2 currently doesn't support it (and I don't have HiDPI screen to test it :smiley:)...

varlesh commented 8 years ago

You want remove black background or add transparent? I'm not have HiDPI too... hm, icons have SVG-fromat and maybe port to other size. Only i'm not shure Windows support showing SVG's or only PNG's on program?

varlesh commented 8 years ago

Added not-background version https://github.com/varlesh/QMPlay2-Concept/commit/162470f1998d0ac1de0e8860269f2f0ad7def7c2: screenshot_20160628_213026

varlesh commented 8 years ago

extensions added https://github.com/varlesh/QMPlay2-Concept/commit/9afbf3e5538c591ef7c030bb233e400ec20f6ae8 screenshot_20160629_114537

varlesh commented 8 years ago

Any versions good look with dark themes: screenshot_20160629_115852 screenshot_20160629_115914 But i like background version, because all icons have one scale

zaps166 commented 8 years ago

But i like background version

Dark background also looks Ok for me :)

Licesne (I'm not a lawyer):

Does it mean that if I'll include these icons the QMPlay2 will be now on GPL license?

About modules icons:

Is it possible to do a little fixes for this :) ?

varlesh commented 8 years ago

XVideo fixed, but i'm not have idea how add Tux :) License changed to LGPL: https://github.com/varlesh/QMPlay2-Concept/commit/f3f368e1322a911d2bebe426490120f222657530

zaps166 commented 8 years ago

XVideo looks good to me now :+1:, I'll try new icons soon :)

but i'm not have idea how add Tux

Icons can be fixed in any time, right? :smiley: So we can defer it now :)

varlesh commented 8 years ago

Maybe better use as original icon style for ALSA? alsa-logo

alsa-2

varlesh commented 8 years ago

I'm add another ALSA icon, fix colors on Subtilte and small fix OpenGL2. Nobackground-version removed. https://github.com/varlesh/QMPlay2-Concept/commit/a9a6141c8e38f084a28d854dc9c98f4f5a7bd09a https://github.com/varlesh/QMPlay2-Concept/commit/fa0cccb82d3cc5616cd59e22fa9685d285518d61

zaps166 commented 8 years ago

Hmm, ALSA looks good :) but the Tux was cute :smiley: Visualizations looks weird :smile: but I don't have good idea - maybe something associated with FFT spectrum, oscilloscope or something else?

Also OpenGL looks better :+1:

varlesh commented 8 years ago

fixed https://github.com/varlesh/QMPlay2-Concept/commit/5604080a81cfd07d49343e1b5941cd51a7db384f

zaps166 commented 8 years ago

:+1: :)

zaps166 commented 8 years ago

Currently I don't want to create icon themes :smiley: (maybe later). I can try to replace QMPlay2's icons, OK? Modules icons will be in modules directories, etc., so where should I put license (is the same, so it is needed?) and authors files? The icons theme name is "Concept", right?

Little fixes:

Without Tux the ALSA-2.svg is better :smile:

zaps166 commented 8 years ago

Missing icon: media-playback-pause

zaps166 commented 8 years ago

About the black background: Looks very good on modules list, but doesn't look good on playlist or on context menu... :(

zaps166 commented 8 years ago

folder-orange.png and folder.png should be 22x22 as default

varlesh commented 8 years ago

QMPlay2-Concept this temporary repo, you merge icons and i'm delete. Need only AUTHORS. Icons fixed https://github.com/varlesh/QMPlay2-Concept/commit/d7ece30ed54e3dfc9e12a3ab6e1d9fa92c0f93cb I'm change color line on filters icons and reduce logo.

zaps166 commented 8 years ago

So I'll create AUTHORS for me, you and for other contributors, is it OK :) ?

archive-remove - i know that its name is archive, but it can look more like playlist i.e. white color or something (similar to Oxygen, because it was white) :)

zaps166 commented 8 years ago

I'll merge icons into my temporary branch (maybe today), so I'm waiting for last fixes :)

I don't know what to do with dark background on e.g. playlist, maybe it needs two different icons (with and w/o background)?

varlesh commented 8 years ago

folders fixed https://github.com/varlesh/QMPlay2-Concept/commit/81be7643a8e42e167f1c8c7ebd55dfa0e759738f Maybe disable this icons on context menu?

zaps166 commented 8 years ago

Btw. I'm using this for creating PNG:

for f in *.svg; do
    inkscape -z -e $f.png $f
    rename .svg.png .png *.svg.png
done
varlesh commented 8 years ago

rsvg-convert good util too

varlesh commented 8 years ago

screenshot_20160703_204536

like that archive-remove ?

zaps166 commented 8 years ago

like that archive-remove ?

looks good, I'll see in QMPlay2 :)

zaps166 commented 8 years ago

applications-multimedia

Now everything is black

varlesh commented 8 years ago

archive icon fixed https://github.com/varlesh/QMPlay2-Concept/commit/4a1708f833f585ddb17b32247ed6437b29bb4c4f

zaps166 commented 8 years ago

Ok!

applications-multimedia I thought about adding a little gradient to the black note, the blue arrow was OK

varlesh commented 8 years ago

all blue, note and play?

varlesh commented 8 years ago

or for example screenshot_20160703_210405

zaps166 commented 8 years ago

Good :smile:

And what about green note (with gradient like above) and blue (like before) arrow?

zaps166 commented 8 years ago

Btw. do you able to do new icons if I'll add a now module?

varlesh commented 8 years ago

multimedia fixed https://github.com/varlesh/QMPlay2-Concept/commit/eb206a7b7e5df2842c5ed9d6ebff8a614b8dbec1 Yes, what you need?

zaps166 commented 8 years ago

1 2 3

You can see that here that black background isn't good... So the only thing is to create two icons: for module and for context menu/playlist. I think I'm able to remove the background in Inkscape (only for some modules) :)

zaps166 commented 8 years ago

multimedia fixed

Ok, testing - this icon is the most frequent icon, so I want it to be as good as possible :)

Yes, what you need?

  1. Future modules :)
  2. QMPlay2 lacks of icons in context menus, so if you have a time you can always do some icons :)
varlesh commented 8 years ago

need add other sizes for context, because more icons blurred. For example, Files, Directory, YouTube and etc

zaps166 commented 8 years ago

need add other sizes for context, because more icons blurred. For example, Files, Directory, YouTube and etc

Yes, but it is less important (later). The best idea is to use SVG, but it needs QtSvg module :/