search

zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
47 stars 34 forks source link

Low FPS in certain situations with HandyNotes Shadowlands #35

Closed 7MinutesDead-Git closed 3 years ago

7MinutesDead-Git commented 3 years ago

While minimap rotation is enabled, if you highlight a rare boss icon in Icecrown to show the spawn rotation path, then whenever you turn your character and the minimap rotates, your framerate will drop tremendously.

It's a bit strange to describe so I recorded some footage of it. Watch the FPS counter in the top left to see effects: https://streamable.com/6ic1kx

I'm not sure if it's an interaction with ElvUI or if it does this by default, but either way it can be resolved by just disabling minimap rotation. But I thought I'd submit the issue.

Krovikan commented 3 years ago

ElvUI_Klix was a problem related with https://github.com/zarillion/handynotes-plugins/issues/27

The FPS drops is related with the MBB addon in this link https://github.com/zarillion/handynotes-plugins/issues/29

Now the question is, you have installed the MBB addon?

Regards

7MinutesDead-Git commented 3 years ago

Now the question is, you have installed the MBB addon?

I have not. My enabled addons are as follows:
Wow 2020-11-15 10-31-23

Krovikan commented 3 years ago

What version of HandyNotes and what from HandyNotes: Shadowlands are you using?

Regards

7MinutesDead-Git commented 3 years ago

What version of HandyNotes and what from HandyNotes: Shadowlands are you using?

HandyNotes shows 1.6.0, and HandyNotes Shadowlands shows v17.

Here's the settings:
image image

zarillion commented 3 years ago

There's definitely a lot of POIs to redraw there. I have added a new option to change the refresh rate of minimap POIs when 'Rotate Minimap' is enabled.

image

I determined empirically that a default value of 0.05 appears the alleviate the stress on FPS when redrawing many POIs at once without causing the rotation of the textures to get too out of sync with player facing before the next refresh. The slider allows you to increase this value further if the rotational jitter it causes does not bother you.

This was just released in v18.

zarillion commented 3 years ago

I pondered this some more and found a different solution that updates the POI texture rotations fast enough to do it on every update to player facing again. I've removed the above option for v19, which I will release some time soon. For now, the temporary option in v18 will help.

7MinutesDead-Git commented 3 years ago

Hell yeah nice job man. Thanks for looking at this.