search

zarillion / handynotes-plugins

A collection of HandyNotes plugins for World of Warcraft.
Other
47 stars 34 forks source link

Adds option to toggle the NPC ID display on nodes #444

Closed Protuhj closed 1 month ago

Protuhj commented 1 month ago

I'm not sure if the if statement in nodes.lua is sufficient enough to only catch NPCs, but in my limited testing, it works just as I expected.

Attempts to satisfy the simpler ask of #434.

Krovikan commented 1 month ago

The PR have errors. Check, please.

Regards

Krovikan commented 1 month ago

Now Lint is OK. The max length of a line is 80 characters.

Regards

zarillion commented 1 month ago

The if-statement is indeed too generic and catches thing that are not NPCs:

image

Instead I moved the handling of this option to the Rare class itself and now render it after the name if the option is enabled:

image

Not that this option only works for simple rare nodes. For complex multi-rare nodes this won't do anything:

image