Ability to pass our own sparql client to Source

zazuko / rdf-cube-view-query

RDF Cube View Schema query library

2 stars 3 forks source link

Ability to pass our own sparql client to Source #83

Open ptbrowne opened 1 year ago

ptbrowne commented 1 year ago

In visualize I've decorated the sparqlClient.query.select method to have timings and to pass the queries to the client for debugging purposes. Throughout our server code, we use our own sparqlClient that is decorated. Only the rdf-cube-view-query are not tracked, because the client is created each time the sources uses it. It would be nice to be able to pass the client to the Source constructor for it to be used by the views that use this Source.

sosiology commented 10 months ago

@ktk @MartinaElsawy is this issue on your radar and do you have a timeline on when it could be implemented? BAFU has reached out to ask if we could support in tackling this issue which is why we wanted to first follow up with you.

Also see comment from Thomas here: https://gitlab.ldbar.ch/bafu/visualize/-/issues/551#note_13405

cc: @rdataflow, @adintegra, @bprusinowski

MartinaElsawy commented 10 months ago

Thanks @sosiology I will transfer this one to the board and see how and when we fit it in as subtask for exisiting #551