zazuko / xrm

A friendly language for mappings to RDF
MIT License
1 stars 0 forks source link

Unify Prefix Labels #73

Closed nnamtug closed 4 years ago

nnamtug commented 4 years ago

https://github.com/zazuko/rdf-mapping-dsl/blob/bda63d6d3eb6e42164ad09f69b00973311679a9f/runtime-EclipseXtext/airport-mapping/vocabularies.xrm#L2

Separating character ':' is used in the payload of Prefix.label in DSL-Files. This looks suspicous, since a separating character should be part of the tooling, not of the payload. For example see #34 , there only pure payload is meant to put in label. I propose to validate not having separators in the payload and implement them in the generators.

Implies changes in existing DSL files.

@mchlrch please check.

mchlrch commented 4 years ago

Yes, this needs harmonization. Prefix declarations should be uniform inside the DSL. Thanks for pointing this out.

only pure payload is meant to put in label. I propose to validate not having separators in the payload and implement them in the generators.

Yes, let's change this as you propose.

Implies changes in existing DSL files.

That's fine. Validations will mark the places where changes are needed. Providing a quickfix would be nice, also for people that are used to turtle and maybe copy/paste prefix definitions from turtle files.

mchlrch commented 4 years ago

Tested and works. Nice that it comes with quickfix included