The intro plugin is dependend on jQuery

zazuko / zack-search

A highly adaptable HTML5 only component that enables interactive access and search data from a SPARQL endpoint.

10 stars 1 forks source link

The intro plugin is dependend on jQuery #32

Open l00mi opened 6 years ago

l00mi commented 6 years ago

We like to use it anyway ...

but we should handle it somehow that jQuery gets only loaded if the intro plugin is actually loaded.

Lets discuss.

StrubT commented 6 years ago

To clarify:

bootstrap.native has already been included (via CDN).
bootstrap-tour depends on both Bootstrap and jQuery.

Using jQuery would allow us to use bootstrap-tour and solve the IE exception (zazuko/www.alod.ch#56) at the same time. I continued to use CDNs rather than using npm to include the libraries.

Both decisions are up for discussion.

vhf commented 6 years ago

If all we need jQuery for is this tour feature, there are lightweight alternatives that don't depend on jQuery, e.g. https://github.com/kamranahmedse/driver.js

l00mi commented 6 years ago

We changed already 3 times the framework (-: https://github.com/zazuko/www.alod.ch/issues/36

Are you confident that this is stable and maintained for some time?

For the time being we only use it for data.alod.ch so lets stick with it.