zbycz / osmapp

Lets make a universal app for OpenStreetMap
https://osmapp.org
GNU General Public License v3.0
182 stars 15 forks source link

Wikimedia audio files #524

Open Dlurak opened 1 week ago

Dlurak commented 1 week ago

When an asset fetched from Wikimedia Commons is an audio file (such as an .ogg file), a generic and unattractive speaker icon is displayed as the thumbnail. This happens because OsmAPP currently uses the file's thumbnail, and for audio files, that thumbnail is a speaker icon. Displaying this next to real image thumbnails can be confusing and unappealing.

Suggested Behavior

Examples

zbycz commented 1 week ago

Good catch, thanks.

This is happening because this sound is the first item in Wikimedia Commons category. I added the category fetching only recently, and it definitely needs some polishing. My idea was to display many photos from the category, but sometimes the photos are not that unique, so I decided one is enough and it can serve as a reminder for the user, that there is a category there. (I am not sure if the info icon in bottom is actually used or not 😅 )

My other idea was to display eg. 4 images in one "gallery slot", but it would make the already complicated imageDefs+slider css unbearable I think. 😅

Adding an audioplayer is, i think, above the scope of this project. It would make sense if OSM editors link such files frequently, but I have never seen it in wikimedia_commons tag and that we randomly choose this file from category and show it in image gallery is more of a bug.

ad Skip displaying non-image file types) we can fetch eg 10 items, and filter images out. Also, see the docs to find if we can request only images. cmnamespace looks promising, but probably won't work: https://commons.wikimedia.org/wiki/Help:Namespaces .