tcp connection verification doesn't support usage of ip addresses

zebrunner / mcloud-device

Android, Appium and STF provider in Docker.

9 stars 8 forks source link

tcp connection verification doesn't support usage of ip addresses #192

Closed vdelendik closed 4 months ago

vdelendik commented 4 months ago

parsing tcp //192.168.88.88:7250 is not supported, only DNS name usage is possible like tcp://demo.zebrunner.farm:7250.

@azarouski, please review your parse logic to support usage of ip address

parse_url_for_nc() {
  # tcp://demo.zebrunner.farm:7250 -> demo.zebrunner.farm 7250
  echo "$1" | sed -nE 's/^([a-z]*:\/\/)*([a-z\.]+):([0-9]*)/\2 \3/pI'
}

vdelendik commented 4 months ago

grep cut using : as a separator might be the best option. let's review IPv6 use case also

vdelendik commented 4 months ago

fixed using : as separator

dhreben commented 4 months ago

Basic acceptance with iOS-Preferences-Test ,Mobile-iOS-Safari-Test , Android-Demo-Test successfully completed. Video, screenshots and logs are available.