zed-industries / extensions

Extensions for the Zed editor
797 stars 332 forks source link

Add Quiet Light theme #1151

Open wooowchik opened 1 month ago

wooowchik commented 1 month ago

Check for existing issues

Misc notes

Without rewriting everything from scratch, I'll leave you here the link to my original post which I've made on Reddit: https://www.reddit.com/r/ZedEditor/comments/1ebs7pe/eye_tiredness_a_friendly_vision_light_color_theme/

Thank you for your attention.

I wish to ask the people around if it could be possible to merge a color Theme like : Quiet Light from Visual Code in to Zed. Asking exactly for this particular color theme, because this one is the only one which don't tear my eyes after long time of coding.

https://marketplace.visualstudio.com/items?itemName=onecrayon.theme-quietlight-vsc

blaqat commented 1 month ago

I'll work on this tomorrow. Can check progress here

Here's current comparison to VSCode Code-main rs — Playground-Capture-019074

wooowchik commented 1 month ago

Pretty everything looks perfect! the only thing to fix is : The bottom purple bar, because Zed's letters and symbols is black which doesn't match with the purple background of the bottom purple bar.

wooowchik commented 1 month ago

Screencast from 2024-08-09 04-17-57.webm In this video I show issues with color matching. Where I use to point the cursor, I show the zones which needs complete re-work, because the colors is completely faded or looks very weak on the background, like the weak grey inside my file explorer.

blaqat commented 1 month ago

@wooowchik I'll add more contrast for the ignored and other ui text in the next update.

As for the terminal, I'm not sure why yours is showing white text, but I believe it has to do with either your local bash or cargo configuration because the terminal highlights do not have any white.

Could you neofetch (or something adjacent) to confirm? Zed Preview-lib rs — rust-Capture-019923

I did figure out cargo does not respect any theme's colors which leads me to believe is a cargo config issue. I have the issue with any dark theme. Zed Preview-lib rs — rust-Capture-019927

wooowchik commented 1 month ago

I did figure out cargo does not respect any theme's colors which leads me to believe is a cargo config issue. I have the issue with any dark theme.

So what about this? Material Dark theme is not affected by exactly this issue, pls check: https://github.com/zed-industries/extensions/issues/1127#issuecomment-2277071020

blaqat commented 1 month ago

It is actually exactly how I described. Cargo does not respect the terminal colors notice how no matter what theme you use your cargo output colors remain the exact same. (This screenshot is taken from your previous video and the Material Dark theme screenshot) Arc-356451194-23a31151-7d18-42bf-b023-9b75a57f9073 png (1920×1080)-Capture-019941

To fix this you need to add this to your $CARGO_HOME/config.toml file (or one in the project's config.toml).

[expand]
theme = "ansi"

OR simply run cargo expand --theme="ansi" instead. (Information from the cargo expand repo)


Once you do this fix it should start respecting the terminal themes like so: Zed Preview-config toml — rust-Capture-019957

wooowchik commented 1 month ago

To fix this you need to add this to your $CARGO_HOME/config.toml file (or one in the project's config.toml).

Everything works, Thanks you very much! Screenshot from 2024-08-10 02-55-02

wooowchik commented 1 month ago

My last complain is this super weak grey inside my file explorer which is not playing nice with the background. Basically it's looking such faded that's pretty hard to even read the character

Thanks.