search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.51k stars 3.13k forks source link

Rename "prev" to "previous" in command palette actions #10167

Open hferreiro opened 7 months ago

hferreiro commented 7 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Some commands use the word "previous" while a few others "prev". The former should be used, as it can be more easily matched when filtering.

Environment

Zed: v0.129.2 (Zed) OS: macOS 14.4.1 Memory: 32 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

JosephTLyons commented 7 months ago

I had this old PR that did a bunch of unifying of names in the keybindings, including the prev and previous discrepancy. We decided not to merge it because it had a lot of breaking changes. Since then, we've ended up allowing more breaking changes to come through (especially ones that bring us closer to being 1:1 with VS Code and our default keymap) and we are better now with reporting these breaking changes to the user in the release notes each week. Just adding it here in case someone else wants to use it to see what all I flagged as inconsistent.

However, for anyone wanting to do a change like this, I'd still recommend bringing them up with team before doing them, in case others on the team thing we should provide some sort of backwards compatible thing to ease the transition.

hferreiro commented 7 months ago

I wasn't aware that the command labels were taken from the actual commands in the code. I understand this can be contentious. That said, let me know if just the prev/previous rename would be accepted and I might try to pick that from your PR.

github-actions[bot] commented 1 month ago

Hi there! 👋 We're working to clean up our issue tracker by closing older issues that might not be relevant anymore. Are you able to reproduce this issue in the latest version of Zed? If so, please let us know by commenting on this issue and we will keep it open; otherwise, we'll close it in 7 days. Feel free to open a new issue if you're seeing this message after the issue has been closed. Thanks for your help!

hferreiro commented 1 month ago

Still an issue.