zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.04k stars 3.06k forks source link

Extraneous output from new Ollama Yi-coder model #17702

Open pjv opened 2 months ago

pjv commented 2 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

When using the new yi-coder model via Ollama, after what i think should be the end of the output the assistant pane shows what looks like some extraneous template text and then the model continues spewing out maybe-vaguely-related text.

Here are two screenshots of the same prompt processed directly via the Ollama command line vs. through the assistant panel in Zed preview v. 0.153.1:

Ollama CL:

SCR-20240911-hntg

Zed Assistant pane:

SCR-20240911-hqoq

In the second screenshot, the assistant continues producing tangentially related text until I esc it to force it to stop. The same template-looking text/tags re-appear in that extraneous output periodically like this:

SCR-20240911-hrsw

My Zed Default prompt is empty and no other custom prompts were used.

Environment

Zed: v0.153.1 (Zed Preview) OS: macOS 14.6.1 Memory: 64 GiB Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log


pjv commented 1 month ago

May be an upstream issue: https://huggingface.co/01-ai/Yi-Coder-9B-Chat/discussions/6#66f3b270cbe35a1ea9982255

pjv commented 1 month ago

OTOH, i have now tested four separate interfaces running against the same Ollama server:

  1. ollama command line
  2. open webUI
  3. android ollama client
  4. Zed

and the first three all correctly terminate output reasonably where zed exhibits the behavior in the OP.