search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
50.8k stars 3.15k forks source link

Splitting option in file finder doesn't work if selected with Arrows + Enter #21077

Closed marcospb19-cw closed 6 days ago

marcospb19-cw commented 6 days ago

Check for existing issues

Describe the bug / provide steps to reproduce it

Splitting option does nothing (not even open the file) if selected with arrow keys and enter.

It works if we click on the option or use the shown hotkeys.

If it is not supposed to be selectable in such way, I believe the options shouldn't be highlighted when we use the arrow keys.

Related to #20507, cc @SomeoneToIgnore

Environment

Zed: v0.162.5 (Zed) OS: macOS 14.7.1 Memory: 36 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log ``` 2024-11-22T16:06:02.798636-03:00 [INFO] set status on client 145800: ConnectionLost 2024-11-22T16:06:02.799205-03:00 [INFO] set status on client 145800: Reauthenticating 2024-11-22T16:06:02.799412-03:00 [INFO] set status on client 145800: Reconnecting 2024-11-22T16:06:03.28489-03:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc 2024-11-22T16:06:04.573404-03:00 [INFO] add_connection; 2024-11-22T16:06:04.575129-03:00 [INFO] set status on client 145800: Connected { peer_id: PeerId { owner_id: 614, id: 1421401 }, connection_id: ConnectionId { owner_id: 0, id: 8 } } 2024-11-22T16:48:55.793455-03:00 [ERROR] connection error: delay between messages too long 2024-11-22T16:48:55.795526-03:00 [INFO] set status on client 145800: ConnectionLost 2024-11-22T16:48:55.796498-03:00 [INFO] set status on client 145800: Reauthenticating 2024-11-22T16:48:55.796938-03:00 [INFO] set status on client 145800: Reconnecting 2024-11-22T16:48:57.664467-03:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc 2024-11-22T16:48:58.812015-03:00 [INFO] add_connection; 2024-11-22T16:48:58.812908-03:00 [INFO] set status on client 145800: Connected { peer_id: PeerId { owner_id: 614, id: 1447216 }, connection_id: ConnectionId { owner_id: 0, id: 9 } } 2024-11-22T17:16:07.857285-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.rustup/toolchains/1.81-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/time.rs" 2024-11-22T17:16:09.155606-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.7/src/builder/arg.rs" 2024-11-22T17:16:16.746217-03:00 [ERROR] error upgrading view 2024-11-22T17:19:56.066517-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.rustup/toolchains/1.81-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/option.rs" 2024-11-22T17:19:56.694472-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.rustup/toolchains/1.81-aarch64-apple-darwin/lib/rustlib/src/rust/library/core/src/option.rs" 2024-11-22T17:20:01.158405-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.7/src/builder/arg.rs" 2024-11-22T17:21:14.87298-03:00 [ERROR] error upgrading view 2024-11-22T17:21:19.314016-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.7/src/builder/arg.rs" 2024-11-22T17:21:19.397048-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_derive-4.5.5/src/lib.rs" 2024-11-22T17:21:19.412758-03:00 [WARN] skipping diagnostics update, no worktree found for path "/Users/joaobezerra/.cargo/registry/src/index.crates.io-6f17d22bba15001f/clap_builder-4.5.7/src/builder/arg.rs" ```
notpeter commented 6 days ago

I can reproduce. It does not work when pressing "Enter to select" but does work when clicking with the mouse or using the letters (h, j, k, l).

Thanks for reporting.