zeel01 / MonsterBlocks

A Foundry VTT module to add NPC sheets that faithfully reproduce the appearance of D&D 5e monster statblocks.
29 stars 26 forks source link

Skill Labels disappear after editing #206

Open brazzam opened 1 year ago

brazzam commented 1 year ago

The labels for Skill modifiers disappear after editing any information on the statblock, e.g. HP.

The labels stay missing after closing and reopening the statblock.

Opening the "Sheet" selection window and re-selecting Monster Blocks and therefore reloading the statblock will bring them back. However, they will disappear again on the next edit.

On load:

before editing

The issue, shown after editing HP:

after editing

I am using Foundry 10 (Build 291), the latest dnd5e Game System, and the current Monster Blocks module (3.3.5)

zeel01 commented 1 year ago

What... I thought I got that fixed. Not sure why it's intermittent. I'll have to take another look.

Benethor92 commented 1 year ago

Can confirm, still happening sometimes (but not always) grafik

zeel01 commented 1 year ago

Are you getting any errors along with this? Are there specific steps that can always reproduce the issue?

brazzam commented 1 year ago

As for errors, I don't get any errors on the canvas itself, but the console goes wild, even when just opening a statblock with Monster Blocks. Then, more errors will appear when the issue actually occurs.

As for repeatability, for me this is infinitely repeatable, it happens every time. Just open a stat block, edit something, and the labels disappear. This happens with HP changes, editing a feature, anything. I've also tried it on every statblock in my current world, and it happens to all of them.

And once the issue presents itself, closing and opening the statblock does not resolve the issue. The only way I've found to make the labels return is to hit the "[Gear Icon] Sheet" button and then hit "Save Sheet Configuration".

I recorded a video showcasing the issue: Monster Blocks Issue

Notes:

seanpg71 commented 1 year ago

I'm able to reproduce this consistently by showing and then hiding the biography.

coolfox09 commented 1 year ago

Will there be an update regarding this soon? This module is such a time saver as a DM and it's my preferred sheet for all my NPCs/Monsters, but the skill labels disappearing with every edit is such a hassle. And only fixable on my end by constantly switching back and forth between the default sheet to the monster blocks sheet.

zeel01 commented 1 year ago

Yeah, I've worked on this a few times. There are some pretty problematic underlying issues that are tricky to tackle. I thought I had this fixed a few times, and then found new problems. It's definitely still high priority, it's just a weirdly hard problem due to some things that changed in the system/Foundry, and I haven't had a lot of time.

brazzam commented 1 year ago

@zeel01 Thanks for your work hunting down the issue!

@coolfox09 in the meantime, the quickest way I’ve found to reset the statblock is to hit the “[gear icon] Sheet” button on the top right of the sheet, and then immediately click the “Save Sheet Configuration” button on the popup. This way, you dont have to wait on the sheet to swap to the Default Sheet and back and is a fraction of time shorter/less annoying.

coolfox09 commented 1 year ago

@zeel01 Thank you so much Josh! Glad to hear it's being worked on at all. The bright side is it's still funcitonal and works great and not totally broken and we appreciate evertyhing you're doing and the time spent on the module!!!

@brazzam thank you! i'll definitely be doing that to restore it quicker :)

friction1 commented 1 year ago

I also have this issue. Happy to provide any data as needed.

kajishun commented 1 year ago

i can also confirm this issue. happy to help in any way possible. thank you for this mod!