zeel01 / MonsterBlocks

A Foundry VTT module to add NPC sheets that faithfully reproduce the appearance of D&D 5e monster statblocks.
29 stars 26 forks source link

Compatibility with Foundry V11 and dnd5e 2.2.0 #211

Closed nschoenwald closed 1 year ago

nschoenwald commented 1 year ago

Will this module be updated for the new releases of foundry and dnd5e? It's my favorite npc sheet and I would love to keep using it!

zeel01 commented 1 year ago

Yes, it will be updated. I can't guarantee a timeline yet. The v11 release may be marked as "stable" but I would highly discourage updating any ongoing campaigns to v11 for at least a few weeks to account for bugs and various module updates.

nschoenwald commented 1 year ago

Awesome, that's great to hear!

Josh Olsen @.***> schrieb am Do., 25. Mai 2023, 17:26:

Yes, it will be updated. I can't guarantee a timeline yet. The v11 release may be marked as "stable" but I would highly discourage updating any ongoing campaigns to v11 for at least a few weeks to account for bugs and various module updates.

— Reply to this email directly, view it on GitHub https://github.com/zeel01/MonsterBlocks/issues/211#issuecomment-1563102915, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARIJNCBNJF6H5E2E3KMTI6DXH522PANCNFSM6AAAAAAYO5EC3A . You are receiving this because you authored the thread.Message ID: @.***>

friction1 commented 1 year ago

If this is helpful, I've updated dnd5e but still running V11. I have the following errors from Monster Blocks.

Screenshot 2023-05-25 at 4 48 44 PM Screenshot 2023-05-25 at 4 49 28 PM Screenshot 2023-05-25 at 4 49 05 PM
evan-rash commented 1 year ago

@zeel01 - unfortunately it looks like updating to dnd5e 2.2.0 causes some issues (even staying on foundry v10)

image

It looks like these two calls are the issues.

image

Poking into the data object, I can find data.hp.formula but I can't find the XP information. Seems like it's been moved somewhere else? There is a data.source.details.cr property, but I can't find XP. Maybe that was removed?

image

evan-rash commented 1 year ago

@zeel01 - do you accept PRs? I started trying to debug the issues and I've been slowly working my way through all the places that have to be refactored because of the changes to data.*

If you do, here's the PR - https://github.com/zeel01/MonsterBlocks/pull/212

Benethor92 commented 1 year ago

Any news on updates for v11? I just updated and out of 50+ modules this is the only one still not working with v11 :/

kajishun commented 1 year ago

i wish! i love this module!

On Wed, Oct 11, 2023 at 07:27 Benethor92 @.***> wrote:

Any news on updates for v11? I just updated and out of 50+ modules this is the only one still not working with v11 :/

— Reply to this email directly, view it on GitHub https://github.com/zeel01/MonsterBlocks/issues/211#issuecomment-1757473473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOLLL4GPBT6FWUBHZF54N2TX6Z7BLANCNFSM6AAAAAAYO5EC3A . You are receiving this because you are subscribed to this thread.Message ID: @.***>

zeel01 commented 1 year ago

Merged https://github.com/zeel01/MonsterBlocks/pull/212 and published release.