search

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning
https://github.com/apps/semantic-pull-requests
Apache License 2.0
1.24k stars 122 forks source link

Fix user config #154

Closed kevin-360 closed 2 years ago

kevin-360 commented 3 years ago

Resolves #141

Use the probot context object to acess the user-defined config instead of the deprecated probot-config package.

kevin-360 commented 3 years ago

Hey @zeke, I've run into the problem described in https://github.com/zeke/semantic-pull-requests/issues/141 and wanted to propose @sapkra's fix.

This is my first time submitting code here, please don't hesitate to tell me if I can improve something.

sapkra commented 3 years ago

@kevin-360 Thank you for your work but I'm still not sure if it really fixes the problem. It was just a guess.

kevin-360 commented 3 years ago

@sapkra Ok thanks for your answer, I wasn't sure either, but it was worth the shot.

@zeke Do you think the probot upgrade is doable? I'd be happy to help and fix this issue.

zeke commented 3 years ago

Do you think the probot upgrade is doable? I'd be happy to help and fix this issue.

Sure. I kicked off a CI build here but it appears to be failing. Wanna take a look at that?

kevin-360 commented 3 years ago

@zeke Ok, thanks. I tried cloning the repo and running unit tests, but I couldn't get them to all pass before starting my work. So I'll leave it at that for the moment, sorry.

zeke commented 2 years ago

This PR is old and inactive so I'm going to close it. If anyone wants to pick it back up let me know.