chore: Bump node version number from 8 to 14.

zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning

https://github.com/apps/semantic-pull-requests

Apache License 2.0

1.24k stars 122 forks source link

chore: Bump node version number from 8 to 14. #174

Closed tysonkamp closed 2 years ago

zeke commented 2 years ago

Thanks for the PR. Can you explain why you chose v14?

It looks like that version is in maintenance mode and we should be running on 16 or 18: https://nodejs.org/en/about/releases/

tysonkamp commented 2 years ago

The requestor suggested minimum 12 or 14 (it was a staleness issues). I have no objection to 18 which I believe is current.

tysonkamp commented 2 years ago

Will open a new PR.

zeke commented 2 years ago

No problem, but for future reference you shouldn't have to close and open a new PR. You can push additional commits to the same branch with your changes.