zeke / semantic-pull-requests

:robot: Let the robots take care of the semantic versioning

https://github.com/apps/semantic-pull-requests

Apache License 2.0

1.24k stars 122 forks source link

Pending PR status for "docs: ..." titles #20

Closed levithomason closed 4 years ago

levithomason commented 6 years ago

I noticed the PR status is pending for some of our PRs which have titles with this format:

docs: improve example knobs

You can see the PR here: https://github.com/stardust-ui/react/pull/9

levithomason commented 6 years ago

Note, I just pushed another commit and it seems to have re-triggered the check and passed. The issue appears to be intermittent.

zeke commented 6 years ago

Thanks for reporting, @levithomason.

A fix for semantic message detection was shipped nine days ago: https://github.com/probot/semantic-pull-requests/pull/16 -- was the previous incorrect status reported before that timeframe?

levithomason commented 6 years ago

@zeke here's another example of a PR check that is stagnant at the time of writing. Note the number of title changes trying to correct the check:

https://github.com/stardust-ui/react/pull/336

zeke commented 6 years ago

Ah I see. Unfortunately you can't actually denote a breaking change using the PR title, as the BREAKING CHANGE string needs to be in the Body™ of one of the commits, not in the first line of the commit (aka the Subject™). This is how the Conventional Commits spec is defined.

I'm open to ideas on how to make this easier, whether that means changes to this bot or proposing a change to the Conventional Commits spec to which this bot adheres.

zeke commented 5 years ago

tunnckoCore commented 5 years ago

I don't see how #51 is related to that. The linked #336 simply just doesn't follow the spec.

zeke commented 5 years ago

51 is related because it's about the process for signaling a breaking change.

zeke commented 4 years ago

I think this was a blip in the service. Feel free to re-open if this happens again.